Skip to content

Chore: Fix mypyc setup#7382

Merged
VaggelisD merged 1 commit intomainfrom
vaggelisd/fix_mypyc
Mar 24, 2026
Merged

Chore: Fix mypyc setup#7382
VaggelisD merged 1 commit intomainfrom
vaggelisd/fix_mypyc

Conversation

@VaggelisD
Copy link
Collaborator

The generator extractions PR added *_subpkg_files(src_dir, "generators") twice

@VaggelisD VaggelisD merged commit f0f04d9 into main Mar 24, 2026
9 checks passed
@VaggelisD VaggelisD deleted the vaggelisd/fix_mypyc branch March 24, 2026 14:47
@github-actions
Copy link
Contributor

Benchmark Results

Legend: 🟢🟢 = 5%+ faster | 🟢 = 3-5% faster | 🟩 = 1-3% faster | ⚪ = unchanged | 🟧 = 1-3% slower | 🔴 = 3-5% slower | 🔴🔴 = 5%+ slower

sqlglot

Query main PR diff
tpch 3.1ms 3.2ms 2.2% slower 🟧
short 243us 242us 0.4% faster
deep_arithmetic 8.6ms 8.6ms 0.1% slower
large_in 460.2ms 465.1ms 1.1% slower 🟧
values 511.7ms 512.7ms 0.2% slower
many_joins 12.7ms 12.8ms 0.6% slower
many_unions 49.6ms 51.5ms 3.9% slower 🔴
nested_subqueries 1.6ms 1.7ms 0.5% slower
many_columns 13.7ms 13.7ms 0.2% faster
large_case 41.1ms 41.9ms 2.1% slower 🟧
complex_where 35.7ms 34.4ms 3.7% faster 🟢
many_ctes 21.3ms 20.9ms 1.9% faster 🟩
many_windows 26.2ms 26.8ms 1.9% slower 🟧
nested_functions 883us 879us 0.5% faster
large_strings 6.1ms 6.0ms 0.9% faster
many_numbers 117.4ms 116.5ms 0.8% faster

sqlglot[c]

Query main PR diff
tpch 895us 700us 21.7% faster 🟢🟢
short 69us 71us 2.1% slower 🟧
deep_arithmetic 3.0ms 2.8ms 5.8% faster 🟢🟢
large_in 125.1ms 123.2ms 1.5% faster 🟩
values 131.8ms 131.4ms 0.3% faster
many_joins 2.7ms 2.8ms 2.3% slower 🟧
many_unions 9.4ms 9.5ms 0.9% slower
nested_subqueries 270us 276us 2.3% slower 🟧
many_columns 3.2ms 3.2ms 1.7% slower 🟧
large_case 10.7ms 10.4ms 2.3% faster 🟩
complex_where 7.9ms 7.8ms 0.8% faster
many_ctes 3.9ms 3.9ms 1.8% slower 🟧
many_windows 5.4ms 5.5ms 0.5% slower
nested_functions 178us 181us 1.4% slower 🟧
large_strings 1.5ms 1.4ms 1.0% faster 🟩
many_numbers 27.1ms 27.2ms 0.7% slower

Comment /benchmark to re-run.

@github-actions
Copy link
Contributor

SQLGlot Integration Test Results

Comparing:

  • this branch (sqlglot:vaggelisd/fix_mypyc, sqlglot version: vaggelisd/fix_mypyc)
  • baseline (main, sqlglot version: 0.0.1.dev1)

By Dialect

dialect main sqlglot:vaggelisd/fix_mypyc transitions links
bigquery -> bigquery 23872/23877 passed (100.0%) 21252/21252 passed (100.0%) No change full result / delta
bigquery -> duckdb 2106/2624 passed (80.3%) 0/0 passed (0.0%) No change full result / delta
duckdb -> duckdb 4003/4004 passed (100.0%) 0/0 passed (0.0%) No change full result / delta
snowflake -> duckdb 1508/2674 passed (56.4%) 0/0 passed (0.0%) No change full result / delta
snowflake -> snowflake 65910/65910 passed (100.0%) 63015/63015 passed (100.0%) No change full result / delta
databricks -> databricks 1364/1364 passed (100.0%) 1364/1364 passed (100.0%) No change full result / delta
postgres -> postgres 6040/6040 passed (100.0%) 6040/6040 passed (100.0%) No change full result / delta
redshift -> redshift 7059/7059 passed (100.0%) 7059/7059 passed (100.0%) No change full result / delta

Overall

main: 113552 total, 111862 passed (pass rate: 98.5%), sqlglot version: 0.0.1.dev1

sqlglot:vaggelisd/fix_mypyc: 98730 total, 98730 passed (pass rate: 100.0%), sqlglot version: vaggelisd/fix_mypyc

Transitions:
No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants